Add more tests for dynamic modifier invocation #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Modifier cleanup should definitely run reliably whenever their associated element is removed from the DOM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #1410
Which is ember-modifier/ember-modifier#613
I found that glimmer-vm, at least, seems to be handling this scenario correctly.
So while I debug elsewhere, I figured it may be good to have the extra tests, since I didn't see anything covering the this use case.
UPDATE!
So, it appears this is specific to when the element is removed.
And I'm less certain this is actually an issue.
If an element is removed from the dom, is there anything to cleanup?
Any event listeners attached to the element would be cleaned up by the browser.
Animations running on the element would stop via the browser.
etc.