Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides an implementation to control NDI-enabled PTZ cameras with obs-ptz.
Some code is copied and adapted from DistroAV, which is licensed under GPL-2.0 as well. I've added copyright headers where applicable (
ndi-finder.*andndi.*).Please review this PR carefully. I'm not experienced at all in C++/C, so I might have made grave mistakes. Also, I need help figuring out the cause of the Known Issues I mention below.
Related issue: #56
Implemented
Known Issues
finder_callbackdoes not have the desired effect (cb is invoked, but modifications to dropdown don't appear in UI)source_nameis somehow not persisted across OBS restartsNot planned