Skip to content

Set image 'opacity' attribute in drawImage method #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Set image 'opacity' attribute in drawImage method #53

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62457d4
Set image 'opacity' attribute in drawImage method
kinimesi Jul 28, 2017
bee284b
Fix iVis-at-Bilkent/newt#282
ahmetcandiroglu Jun 20, 2018
29d64b6
Makes SVG self-contained
kinimesi Jul 2, 2019
68b8ef8
temp fix for kinimesi/cytoscape-svg/issues/7
kinimesi Apr 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions canvas2svg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@
* @private
*/
ctx.prototype.__applyStyleState = function (styleState) {
if(!styleState)
return;
var keys = Object.keys(styleState), i, key;
for (i=0; i<keys.length; i++) {
key = keys[i];
Expand Down Expand Up @@ -350,7 +352,7 @@
ctx.prototype.__applyStyleToCurrentElement = function (type) {
var currentElement = this.__currentElement;
var currentStyleGroup = this.__currentElementsToStyle;
if (currentStyleGroup) {
if (false && currentStyleGroup) {
currentElement.setAttribute(type, "");
currentElement = currentStyleGroup.element;
currentStyleGroup.children.forEach(function (node) {
Expand Down Expand Up @@ -1141,9 +1143,12 @@
svgImage = this.__createElement("image");
svgImage.setAttribute("width", dw);
svgImage.setAttribute("height", dh);
svgImage.setAttribute("opacity", this.globalAlpha);
svgImage.setAttribute("preserveAspectRatio", "none");

if (sx || sy || sw !== image.width || sh !== image.height) {
// force embed every images's base64 in SVG by using 'true'
// makes SVG self-contained
if (true || sx || sy || sw !== image.width || sh !== image.height) {
//crop the image using a temporary canvas
canvas = this.__document.createElement("canvas");
canvas.width = dw;
Expand Down