Skip to content

Conversation

lpil
Copy link
Member

@lpil lpil commented Sep 21, 2025

No description provided.

/// ```
///
@internal
pub fn pre_stop(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre_stop -> prep_stop ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

Copy link

@ToddG ToddG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammatical nits

////
//// One feature of OTP applications that makes them different from packages or
//// libraries in other languages is that they have the option of defining a
//// module through which they can be _started_ and _stopped_, and they can
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//// module through which they can be _started_ and _stopped_, and they can
//// module through which they can be _started_ and _stopped_, and they can be

// TODO: test
/// Create a new application recipe from a starter function. This function is
/// called whenever an application is started, and it starts the supervision tree
/// the OTP application.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// the OTP application.
/// of the OTP application.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@karlsson
Copy link
Contributor

karlsson commented Oct 4, 2025

There is an application module in gleam_erlang now, will this be deprecated and the remaining function priv_directory copied to this module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants