-
-
Notifications
You must be signed in to change notification settings - Fork 68
Application module #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Application module #118
Conversation
src/gleam/otp/application.gleam
Outdated
/// ``` | ||
/// | ||
@internal | ||
pub fn pre_stop( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre_stop -> prep_stop ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammatical nits
src/gleam/otp/application.gleam
Outdated
//// | ||
//// One feature of OTP applications that makes them different from packages or | ||
//// libraries in other languages is that they have the option of defining a | ||
//// module through which they can be _started_ and _stopped_, and they can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//// module through which they can be _started_ and _stopped_, and they can | |
//// module through which they can be _started_ and _stopped_, and they can be |
src/gleam/otp/application.gleam
Outdated
// TODO: test | ||
/// Create a new application recipe from a starter function. This function is | ||
/// called whenever an application is started, and it starts the supervision tree | ||
/// the OTP application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// the OTP application. | |
/// of the OTP application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There is an |
No description provided.