Repository navigation
localgateway: dnsconfig writes its config Secret itself - #1543
Merged
Merged
Conversation
Add an unexported publishSecret function and constants in dnsconfig to manage its DNS config Secret directly, removing dependencies on singlepod.PublishDataplaneConfig and singlepod.DataplaneSecretDataKey. Fixes gke-labs#1542
justinsb
requested changes
Nov 22, 2026
justinsb
left a comment
Collaborator
There was a problem hiding this comment.
This is the small writer the issue asks for, with the same Secret name, key and field manager as today. Two small things.
publishSecretreturns nil when the client is nil. That reports success for a Secret it did not write. IfPublishercan hold a nil client, return an error there; otherwise remove the check.clis an abbreviation. The package calls itkubernetesClientelsewhere; use that.
justinsb
approved these changes
Nov 22, 2026
justinsb
approved these changes
Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1542