Skip to content

localgateway: dnsconfig writes its config Secret itself - #1543

Merged
justinsb merged 2 commits into
gke-labs:mainfrom
codebot-robot:issue_1542
Nov 22, 2026
Merged

justinsb merged 2 commits into
gke-labs:mainfrom
codebot-robot:issue_1542

Conversation

@codebot-robot

@codebot-robot codebot-robot commented Nov 22, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #1542

Add an unexported publishSecret function and constants in dnsconfig
to manage its DNS config Secret directly, removing dependencies on
singlepod.PublishDataplaneConfig and singlepod.DataplaneSecretDataKey.

Fixes gke-labs#1542

@justinsb justinsb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the small writer the issue asks for, with the same Secret name, key and field manager as today. Two small things.

  1. publishSecret returns nil when the client is nil. That reports success for a Secret it did not write. If Publisher can hold a nil client, return an error there; otherwise remove the check.
  2. cl is an abbreviation. The package calls it kubernetesClient elsewhere; use that.

@codebot-robot codebot-robot removed their assignment Nov 22, 2026
@justinsb justinsb self-assigned this Nov 22, 2026
@justinsb
justinsb merged commit c56c635 into gke-labs:main Nov 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

localgateway: dnsconfig writes its config Secret itself

2 participants