Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check cargo sort in make check #2572

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Check cargo sort in make check #2572

merged 1 commit into from
Mar 22, 2025

Conversation

naseschwarz
Copy link
Contributor

This is run in CI, so running this offline avoids an unnecessary CI failure.

This Pull Request fixes/closes #{issue_num}.

It changes the following:

  • Adds a make sort target, which runs cargo sort
  • Runs make sort also for make check

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Check cargo sort in make check
7a358d5 
This is run in CI, so running this offline avoids an unnecessary CI
failure.
extrawurst
extrawurst approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, surprised it was not in there yet

@extrawurst extrawurst merged commit dcd9a00 into gitui-org:master Mar 22, 2025
21 checks passed
@extrawurst extrawurst added this to the v0.28 milestone Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrawurst extrawurst extrawurst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging this pull request may close these issues.
2 participants
@naseschwarz @extrawurst