Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the terminal title to gitui ({repo_path}) #2484

Merged
merged 4 commits into from
Mar 18, 2025
Merged

Set the terminal title to gitui ({repo_path}) #2484

merged 4 commits into from
Mar 18, 2025

Conversation

acuteenvy
Copy link
Contributor

This Pull Request fixes/closes #2462.

It changes the following:

  • Always set the terminal title to gitui ({repo_path}).
    It looks like this:
    screenshot

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@cruessler cruessler self-requested a review March 13, 2025 10:31
cruessler
cruessler approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@cruessler cruessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in Alacritty and the window title reflected the directory I had run cargo run in.

@extrawurst
Copy link
Collaborator

@acuteenvy would you mind updating your branch to make it mergable?

@extrawurst extrawurst merged commit 3ede6b5 into gitui-org:master Mar 18, 2025
21 checks passed
@extrawurst
Copy link
Collaborator

Awesome! Thanks!

@acuteenvy acuteenvy deleted the set-term-title branch March 18, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruessler cruessler cruessler approved these changes

Assignees
No one assigned
Labels
merge_ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set terminal title
3 participants
@acuteenvy @extrawurst @cruessler