Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of backoff sequence in db.loose #119

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

EliahKagan
Copy link
Contributor

The sequence of backoff wait times used in gitdb.db.loose is quadratic rather than exponential, as discussed in #115 (comment).

This corrects the variable name by making it more general, and the comment by having it explicitly describe the backoff as quadratic.

This is conceptually related to GitoxideLabs/gitoxide#1815, but this is a non-breaking change, as no interfaces are affected: only a local variable and comment.

The sequence of backoff wait times used in `gitdb.db.loose` is
quadratic rather than exponential, as discussed in:
gitpython-developers#115 (comment)

This corrects the variable name by making it more general, and the
comment by having it explicitly describe the backoff as quadratic.

This is conceptually related to GitoxideLabs/gitoxide#1815, but
this is a non-breaking change, as no interfaces are affected: only
a local variable and comment.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

It looks like this mistake has been following me since my youth 😄.

@Byron Byron merged commit f36c0cc into gitpython-developers:master Jan 27, 2025
7 checks passed
@EliahKagan
Copy link
Contributor Author

No problem!

@EliahKagan EliahKagan deleted the quadratic branch January 27, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants