Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tool-vnc): Fallback to google-chrome from ungoogled_chromium #875

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

axonasif
Copy link
Member

@axonasif axonasif commented Jul 8, 2022

Description

#872 (comment)

Related Issue(s)

Fixes #872

How to test

I pushed the image to my personal docker account and using here for testing, so you could:

  • Create a new workspace from here: https://github.com/axonasif/test/tree/vnc_test
  • Run gp preview $(gp url 6080) --external && chromium --start-fullscreen google.com
    • It should not display the welcome screen
    • It should not prompt to set itself as the default browser.

Release Notes

fix workspace-full-vnc ungoogled_chromium regression

Documentation

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2022

@gitpod-staging
Copy link

gitpod-staging bot commented Jul 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

apt-get update fails when using gitpod/workspace-full-vnc
2 participants