-
Notifications
You must be signed in to change notification settings - Fork 326
Change base image to Ubuntu Jammy #1017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ee6d04
to
9967a57
Compare
218d699
to
573c4bf
Compare
573c4bf
to
0f7f87b
Compare
bb287df
to
149668c
Compare
a92d518
to
f45e39e
Compare
Looks good now |
1c9acdf
to
83e8382
Compare
* `buildkit` 0.10.6 -> 0.11.2 * `dazzle` v0.1.13 -> v0.1.14
Co-authored-by: c3potheds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🧡, Looks good to me ✨
Left some non-blocking comments 🙏🏽
- name: yugabytedb | ||
ref: | ||
- full | ||
- base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good ✨ . Wondering why we were using full
before 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the database images do, it's like an unofficial convention.
RUN curl -fsSL https://pkgs.tailscale.com/stable/ubuntu/jammy.gpg | sudo apt-key add - \ | ||
&& curl -fsSL https://pkgs.tailscale.com/stable/ubuntu/jammy.list | sudo tee /etc/apt/sources.list.d/tailscale.list \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion (non-blocking): How about we do this, this would save us from managing it manually.
RUN curl -fsSL https://pkgs.tailscale.com/stable/ubuntu/jammy.gpg | sudo apt-key add - \ | |
&& curl -fsSL https://pkgs.tailscale.com/stable/ubuntu/jammy.list | sudo tee /etc/apt/sources.list.d/tailscale.list \ | |
RUN curl -fsSL https://pkgs.tailscale.com/stable/ubuntu/$(lsb_release -cs).gpg | sudo apt-key add - \ | |
&& curl -fsSL https://pkgs.tailscale.com/stable/ubuntu/$(lsb_release -cs).list | sudo tee /etc/apt/sources.list.d/tailscale.list \ |
# Install MongoDB Shell aka MongoSH (was part of Mongo 5, but, is separate now) | ||
RUN mkdir -p /tmp/mongosh && \ | ||
cd /tmp/mongosh && \ | ||
wget -qOmongosh.tgz https://downloads.mongodb.com/compass/mongosh-1.8.0-linux-x64.tgz && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried looking for automation of mongosh-*
version. But doesn't find any, on their downloads page & docs. Let's keep it, this way only & will patch the changes in future.
@kylos101 Is it available on dockerhub now ? |
Thx, when will it comes to latest tag ? |
@gengjiawen let me check with @atduarte and get back to you soon. Thank you for asking! |
Looks like still not default one, any timeline ? |
Thank you for asking, @gengjiawen ! May I ask, have you used the tagged image, yet? Any troubles? I will update the timeline later today, and appreciate you asking. cc: @atduarte |
I have used,works pretty good |
* [dev image] update to Jammy Ref: gitpod-io/workspace-images#1017 no more `python-dev` ref: lewagon/data-setup#219 (comment) https://wiki.termux.com/wiki/No_more_-dev_packages * [dev image] update images latest dev image * [ws-manager] avoid false positive linter errors * [ws-daemon] fix ineffectual assignment for err golangci-lint is catching more errors since upgrading to go 1.19.5 * Update to more recent gcloud * Moar timeout
Description
Breaking changes
gitpod/workspace-ruby-2
; Ruby 2.7 is EOL March 31, 2023.gitpod/workspace-mongodb
to mongo v6. v5 doesn't support OpenSSL 3, OpenSSL 3 comes out of the box with Jammy.gitpod/workspace-node-lts
from Node 16 to Node 18, and also ingitpod/workspace-full
gitpod/workspace-node
from Node 18 to Node 19gitpod/workspace-yugabytedb*
, changing itsbase
ref fromfull
. Refer to its dockerfile for backgroundFixes
dazzle build
and not part of any dazzle combination / workspace image), with Go 1.20.gitpod/workspace-full
orgitpod/workspace-go
.gitpod/workspace-full
from Ruby 3.1 to 3.2gitpod/workspace-full
from Python 3.8 to 3.11New features
Related Issue(s)
Fixes: #810, #1016, #1029 and #1012
How to test
Release Notes