Asks which layout is preferred on first entry to the Commit Graph view#5505
Asks which layout is preferred on first entry to the Commit Graph view#5505sergeibbb wants to merge 1 commit into
Conversation
00b3cb6 to
03a6ba3
Compare
Presents a one-time prompt to users on their first entry to the Commit Graph view when it is the main GitLens view, asking them to choose their preferred layout: vertical in the side bar or horizontal in the bottom panel. The prompt uses abstract illustrations to represent the layout options and dismisses permanently after any user interaction (choice or close). Choosing an option automatically moves the Graph view to the selected container. Adds telemetry to track when the prompt is shown and the user's choice. Includes a debugging command (`gitlens.graph.simulate.mainView`) for pre-release testing of this feature. The prompt is designed to avoid conflicting with the graph walkthrough banner. (#5412, #5391, #5505)
03a6ba3 to
49ffb39
Compare
🤖 Augment PR SummarySummary: Adds a one-time onboarding prompt on first entry to the Commit Graph view to ask users whether they prefer the Graph in the Side Bar or Bottom Panel. Changes:
Technical Notes: The prompt is gated to arm only when the Graph’s default container becomes the GitLens side bar (so it remains inert until the related consolidation lands). 🤖 Was this summary useful? React with 👍 or 👎 |
Presents a one-time prompt to users on their first entry to the Commit Graph view when it is the main GitLens view, asking them to choose their preferred layout: vertical in the side bar or horizontal in the bottom panel. The prompt uses abstract illustrations to represent the layout options and dismisses permanently after any user interaction (choice or close). Choosing an option automatically moves the Graph view to the selected container. Adds telemetry to track when the prompt is shown and the user's choice. Includes a debugging command (`gitlens.graph.simulate.mainView`) for pre-release testing of this feature. The prompt is designed to avoid conflicting with the graph walkthrough banner. (#5412, #5391, #5505)
49ffb39 to
dc550ce
Compare
|
augment review |
|
augment review |
Presents a one-time prompt to users on their first entry to the Commit Graph view when it is the main GitLens view, asking them to choose their preferred layout: vertical in the side bar or horizontal in the bottom panel. The prompt uses abstract illustrations to represent the layout options and dismisses permanently after any user interaction (choice or close). Choosing an option automatically moves the Graph view to the selected container. Adds telemetry to track when the prompt is shown and the user's choice. Includes a debugging command (`gitlens.graph.simulate.mainView`) for pre-release testing of this feature. The prompt is designed to avoid conflicting with the graph walkthrough banner. (#5412, #5391, #5505)
dc550ce to
50b9aab
Compare
🟢 Conflict resolved with 100% confidenceComment Resolution details🟢
|
Presents a one-time prompt to users on their first entry to the Commit Graph view when it is the main GitLens view, asking them to choose their preferred layout: vertical in the side bar or horizontal in the bottom panel. The prompt uses abstract illustrations to represent the layout options and dismisses permanently after any user interaction (choice or close). Choosing an option automatically moves the Graph view to the selected container. Adds telemetry to track when the prompt is shown and the user's choice. Includes a debugging command (`gitlens.graph.simulate.mainView`) for pre-release testing of this feature. The prompt is designed to avoid conflicting with the graph walkthrough banner. (#5412, #5391, #5505)
50b9aab to
6bae93b
Compare
Presents a one-time prompt to users on their first entry to the Commit Graph view when it is the main GitLens view, asking them to choose their preferred layout: vertical in the side bar or horizontal in the bottom panel. The prompt uses abstract illustrations to represent the layout options and dismisses permanently after any user interaction (choice or close). Choosing an option automatically moves the Graph view to the selected container. Adds telemetry to track when the prompt is shown and the user's choice. Includes a debugging command (`gitlens.graph.simulate.mainView`) for pre-release testing of this feature. The prompt is designed to avoid conflicting with the graph walkthrough banner. (#5412, #5391, #5505)
6bae93b to
570697e
Compare
Description
Closes #5412 — asks the user on first entry to the Commit Graph view which layout they prefer, with an abstract illustrated preview of each option ("Sidebar › ask on entry" item of #5391).
Screenshot
What it does
A one-time modal (
gl-graph-layout-prompt, hosted in the Graph webview) explaining that the Graph now takes the place of the Home view, and offering two illustrated choices:Choosing moves the view via
vscode.moveViews+<container>.resetViewContainerLocation(both guarded, mirroring Reset Views Layout) to the GitLens side bar container or the bottomgitlensPanelcontainer and re-reveals it. The container reset matters: dragging a container's only view relocates the whole container, so e.g. a Graph sitting in the secondary side bar meansgitlensPanelis the secondary side bar — without the reset, "Bottom Panel" would be a no-op. VS Code persists placement itself, so there's no new setting.The ✕ button, the "Keep my current layout" link, Esc, and backdrop-click all keep the current layout. Any outcome dismisses the prompt for good (new
graph:layoutPromptonboarding key, sogitlens.advanced.skipOnboardingand GitLens: Reset → Onboarding work as expected).The prompt only arms when the Graph's default container is the GitLens side bar:
Today the Graph's default container is the bottom panel, so this is inert for everyone. When the #5391 consolidation makes the Graph the panel's main view, that PR must update this same mapping anyway (otherwise Reset Views Layout would send the Graph back to the bottom panel) — so the prompt arms automatically, with zero coordination. Deliberately no experimental setting.
Deferred to that future PR (noted in code comments): re-adding the CHANGELOG entry (removed here — no announcing an invisible feature), bumping the onboarding
schemastamp if the merge slips past 18.4.0, and an E2E spec.Dev/pre-release preview
GitLens: Simulate Graph as Main View (Debugging)— new command, palette-visible only withgitlens:debugging || gitlens:prerelease. Togglesgraphbetween the panel/side-bar entries ofviewIdsByDefaultContainerIdin-memory (window reload restores) and refreshes the view. While on, Reset Views Layout coherently treats the side bar as the Graph's home.Behavior details
gitlens.views.graph) — the editor-tab graph has no side-vs-bottom placement to choose.startedcase, CTA-clickers would never see the prompt).--gl-gradient-brand,--gl-radius-xl, forced-colors fallback) so the two first-run surfaces read as one family.autofocus-selfongl-dialog, with an explicit focus fallback since Chromium ignoresautofocuson a shadow-hosted dialog); Tab order is Side Bar → Bottom Panel → skip link → ✕ (the ✕ is last in the DOM, positioned top-right visually); the dialog closes before unmount so native focus restoration runs;gl-dialogalso gained alabelproperty →aria-label(slotted headings can't cross the shadow boundary).box-sizingfix forgl-dialog::part(base)so the dialog can't overflow a ~300px side-bar webview.graph/layoutPrompt/shown(once per webview session, remount-safe) andgraph/layoutPrompt/choice(sidebar/panel/dismissed).Verification
Live-exercised against a real instance (fresh profiles): gate inert by default; simulate command arms/disarms at runtime without reload; both move destinations actually relocate the view; all four dismissal paths dismiss without moving; dismissal survives refresh/recreation; both responsive variants fit their real host dimensions; dialog self-focus verified via activeElement probing;
pnpm run checkclean. Later rounds (error-path guards,startedcohort, focus restore) are verified by code-trace and types.Checklist
🤖 Generated with Claude Code