Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract base functionality for WebviewViewProviders into an abstract class #2895

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Oct 2, 2023

This is to help with re-usability but also to make the code more readable since plumbing code etc. get moved out of the concrete class.

This also solves the issue of disposal of event subscriptions at the right time (see #2891).

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners October 2, 2023 08:24
@charisk charisk force-pushed the charisk/abstract-webview-view-provider branch from fd48f7e to 7785555 Compare October 2, 2023 08:31
@charisk charisk merged commit 558b932 into main Oct 2, 2023
@charisk charisk deleted the charisk/abstract-webview-view-provider branch October 2, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants