Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filtering history panel. #2894

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add support for filtering history panel. #2894

merged 2 commits into from
Oct 4, 2023

Conversation

starcke
Copy link
Contributor

@starcke starcke commented Sep 29, 2023 •
edited
Loading

This adds language filtering to the history panel. The implementation is mostly straightforward, we only show unknown languages when All is selected.

Without filter:
image

After java filter:
image

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@starcke starcke mentioned this pull request Sep 29, 2023
Merged
3 tasks
@starcke starcke force-pushed the starcke/lang-context-history branch from 8493074 to d471441 Compare October 2, 2023 12:25
Base automatically changed from starcke/local-query-lang-dto to main October 3, 2023 11:53
@starcke starcke force-pushed the starcke/lang-context-history branch from d471441 to 486180d Compare October 3, 2023 11:57
@starcke starcke marked this pull request as ready for review October 3, 2023 12:59
@starcke starcke requested review from a team as code owners October 3, 2023 12:59
shati-patel
shati-patel approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✨
Thanks for adding the tests too!

@starcke starcke merged commit 55af9bc into main Oct 4, 2023
11 checks passed
@starcke starcke deleted the starcke/lang-context-history branch October 4, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starcke @shati-patel