Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: add HTTP proxy support #90

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

DRAFT: add HTTP proxy support #90

wants to merge 1 commit into from

Conversation

juxtin
Copy link
Contributor

@juxtin juxtin commented Dec 13, 2024

Users reasonably expect that the HTTP_PROXY and HTTPS_PROXY environment variables will be respected by dependency submission actions that rely on this library. However, those users are sadly disappointed for now.

This is little more than some notes on how to proceed here:

  • if HTTP_PROXY or HTTPS_PROXY is set, we'll use that to create a proxyAgent
  • we'll need to pass that proxyAgent as the request.agent param to octokit.request
  • the tests can set up a fake proxy and use it to verify that the settings are being honored

@juxtin juxtin mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant