Merge pull request #61 from github/fix-option-not-found

Fix `indicateDefaultOption` erroring when no options are visible
github · Jul 20, 2022 · 6c2ff80 · 6c2ff80
2 parents e4390ae + 3b5dc97
commit 6c2ff80
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -77,7 +77,7 @@ export default class Combobox {
     if (this.defaultFirstOption) {
       Array.from(this.list.querySelectorAll<HTMLElement>('[role="option"]:not([aria-disabled="true"])'))
         .filter(visible)[0]
-        .setAttribute('data-combobox-option-default', 'true')
+        ?.setAttribute('data-combobox-option-default', 'true')
     }
   }
 

diff --git a/test/test.js b/test/test.js
@@ -288,5 +288,12 @@ describe('combobox-nav', function () {
       combobox.clearSelection()
       assert.equal(document.querySelectorAll('[data-combobox-option-default]').length, 1)
     })
+
+    it('does not error when no options are visible', () => {
+      assert.doesNotThrow(() => {
+        document.getElementById('list-id').style.display = 'none'
+        combobox.clearSelection()
+      })
+    })
   })
 })