-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass --ignore-zeros
to tar
when decompressing zstd
-compressed tarballs
#2768
Conversation
…arballs See comment in the diff for full explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the tar extraction command for zstd-compressed tarballs by adding the "--ignore-zeros" flag to address potential issues when the archive contains trailing zero bytes.
- Updated the argument array in the extractTarZst function to include "--ignore-zeros".
- Added detailed comments explaining the need for the additional flag and linking to a relevant issue for context.
Changes
File | Description |
---|---|
src/tar.ts | Updated the tar extraction command to safely handle trailing zeroes by passing --ignore-zeros. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough investigation and explanation! This looks good to me assuming checks pass.
Do you have an opinion about whether this means we should revert #2767 and return to preferring bsdtar on macOS systems? If we revert that PR, we should add a changenote to this one.
No strong opinion -- using |
See comment in the diff for full explanation.
Merge / deployment checklist