Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch auth for enterprises-release repo from ssh to codeql CI token #2727

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Switch auth for enterprises-release repo from ssh to codeql CI token #2727

merged 4 commits into from
Jan 30, 2025

Conversation

oscarsj
Copy link
Contributor

@oscarsj oscarsj commented Jan 27, 2025 •
edited by aeisenberg
Loading

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Copilot Copilot bot review requested due to automatic review settings January 27, 2025 09:55
@oscarsj oscarsj requested a review from a team as a code owner January 27, 2025 09:55
Copilot
Copilot AI reviewed Jan 27, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
@oscarsj oscarsj requested a review from aeisenberg January 27, 2025 11:22
aeisenberg
aeisenberg reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doing a manual run to make sure it works. https://github.com/github/codeql-action/actions/runs/12994704018/workflow

When this passes, I will ✅ .

@aeisenberg
Copy link
Contributor

Oh...looks like the python version is also a problem. I updated to 3.13.

@aeisenberg
Copy link
Contributor

Latest run: https://github.com/github/codeql-action/actions/runs/12994752985

aeisenberg
aeisenberg previously approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's green!

@aeisenberg aeisenberg dismissed their stale review January 27, 2025 19:59

Dismissing approval because of an internal discussion.

@oscarsj oscarsj requested a review from aeisenberg January 28, 2025 16:35
@oscarsj oscarsj enabled auto-merge January 28, 2025 16:35
@aeisenberg
Copy link
Contributor

Merging with main since required checks have changed.

@oscarsj
Copy link
Contributor Author

oscarsj commented Jan 30, 2025

Changed the PAT to be fine-grained and limited to the enterpries-releases repo. Test run: https://github.com/github/codeql-action/actions/runs/13057974245

@oscarsj oscarsj merged commit 0701025 into main Jan 30, 2025
268 checks passed
@oscarsj oscarsj deleted the oscarsj-patch-1 branch January 30, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarsj @aeisenberg