Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Autobuilder log message referring to build modes clearer #2668

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Draft

Make the Autobuilder log message referring to build modes clearer #2668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e70014
Adds new doc URL for build modes
sidshank Dec 23, 2024
0a7d6c2
Improves autobuilder log message
sidshank Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/autobuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@
(await codeql.supportsFeature(ToolsFeature.TraceCommandUseBuildMode))) ||
config.buildMode === BuildMode.Manual
) {
logger.info(`Using ${config.buildMode} build mode, nothing to autobuild.`);
logger.info(
`Using build mode "${config.buildMode}", nothing to autobuild. ` +
`See ${DocUrl.CODEQL_BUILD_MODES} for more information.`,

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Insert ··

Copilot Autofix AI 7 days ago

Beta Copilot Autofix for ESLint

To fix the problem, we need to ensure that the string concatenation on line 28 is properly indented. This involves adding the necessary spaces to align the code according to the project's coding standards. Specifically, we need to add two spaces before the concatenated string on line 28 to match the indentation level of the previous line.

Suggested changeset 1
src/autobuild.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/autobuild.ts b/src/autobuild.ts
--- a/src/autobuild.ts
+++ b/src/autobuild.ts
@@ -27,3 +27,3 @@
       `Using build mode "${config.buildMode}", nothing to autobuild. ` +
-      `See ${DocUrl.CODEQL_BUILD_MODES} for more information.`,
+        `See ${DocUrl.CODEQL_BUILD_MODES} for more information.`,
     );
EOF
@@ -27,3 +27,3 @@
`Using build mode "${config.buildMode}", nothing to autobuild. ` +
`See ${DocUrl.CODEQL_BUILD_MODES} for more information.`,
`See ${DocUrl.CODEQL_BUILD_MODES} for more information.`,
);
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
);
return undefined;
}

Expand Down
1 change: 1 addition & 0 deletions src/doc-url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ export enum DocUrl {
SCANNING_ON_PUSH = "https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#scanning-on-push",
SPECIFY_BUILD_STEPS_MANUALLY = "https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#about-specifying-build-steps-manually",
TRACK_CODE_SCANNING_ALERTS_ACROSS_RUNS = "https://docs.github.com/en/enterprise-cloud@latest/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#providing-data-to-track-code-scanning-alerts-across-runs",
CODEQL_BUILD_MODES = "https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#codeql-build-modes",
}
Loading