fix: replace rest of anchor tags to external URLs

gitbutlerapp · Aug 29, 2024 · a8784f8 · a8784f8
1 parent 8502b86
commit a8784f8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/apps/desktop/src/lib/components/DecorativeSplitView.svelte b/apps/desktop/src/lib/components/DecorativeSplitView.svelte
@@ -3,9 +3,9 @@
 	import gbLogoSvg from '$lib/assets/gb-logo.svg?raw';
 	import { User } from '$lib/stores/user';
 	import { getContextStore } from '$lib/utils/context';
+	import { openExternalUrl } from '$lib/utils/url';
 	import Icon from '@gitbutler/ui/Icon.svelte';
 	import { type Snippet } from 'svelte';
-	import { openExternalUrl } from '$lib/utils/url';
 
 	interface Props {
 		showLinks?: boolean;

diff --git a/apps/desktop/src/lib/settings/Sidebar.svelte b/apps/desktop/src/lib/settings/Sidebar.svelte
@@ -1,5 +1,6 @@
 <script lang="ts">
 	import SupportersBanner from './SupportersBanner.svelte';
+	import { openExternalUrl } from '$lib/utils/url';
 	import Button from '@gitbutler/ui/Button.svelte';
 	import Icon from '@gitbutler/ui/Icon.svelte';
 	import { goto } from '$app/navigation';
@@ -109,23 +110,21 @@
 
 	<section class="profile-sidebar__bottom">
 		<div class="social-banners">
-			<a
+			<button
 				class="social-banner"
-				href="mailto:[email protected]?subject=Feedback or question!"
-				target="_blank"
+				on:click={async () =>
+					await openExternalUrl('mailto:[email protected]?subject=Feedback or question!')}
 			>
 				<span class="text-14 text-bold">Contact us</span>
 				<Icon name="mail" />
-			</a>
-			<a
+			</button>
+			<button
 				class="social-banner"
-				href="https://discord.gg/MmFkmaJ42D"
-				target="_blank"
-				rel="noreferrer"
+				on:click={async () => await openExternalUrl('https://discord.gg/MmFkmaJ42D')}
 			>
 				<span class="text-14 text-bold">Join our Discord</span>
 				<Icon name="discord" />
-			</a>
+			</button>
 		</div>
 
 		<SupportersBanner />

diff --git a/apps/desktop/src/lib/settings/SupportersBanner.svelte b/apps/desktop/src/lib/settings/SupportersBanner.svelte
@@ -1,4 +1,11 @@
-<a class="banner" href="https://docs.gitbutler.com/community/supporters" target="_blank">
+<script lang="ts">
+	import { openExternalUrl } from '$lib/utils/url';
+</script>
+
+<button
+	class="banner"
+	on:click={async () => await openExternalUrl('https://docs.gitbutler.com/community/supporters')}
+>
 	<div class="benner-content">
 		<h4 class="benner-label text-14 text-bold">Thank you to all GitButler early supporters</h4>
 		<i class="benner-arrow-wrap">
@@ -18,7 +25,7 @@
 		</i>
 	</div>
 	<img class="banner-img" src="/images/banners/support.svg" alt="" />
-</a>
+</button>
 
 <style>
 	.banner {