feat: version history browser (CE3) #4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -317,6 +317,150 @@ export default class CmsService { | |
| return { ref: draftRef, sha: newSha, prev: draftSha }; | ||
| } | ||
|
|
||
| /** | ||
| * Validates that a target SHA exists in an article's ancestry chain. | ||
| * @private | ||
| */ | ||
| async _validateAncestry(tipSha, targetSha, slug) { | ||
| let walk = tipSha; | ||
| let steps = 0; | ||
| const walkLimit = 200; | ||
| while (walk && steps < walkLimit) { | ||
| if (walk === targetSha) return; | ||
| const info = await this.graph.getNodeInfo(walk); | ||
| walk = info.parents?.[0] || null; | ||
| steps++; | ||
| } | ||
| if (steps >= walkLimit) { | ||
| throw new CmsValidationError( | ||
| `History walk limit (${walkLimit}) exceeded for article "${slug}"; SHA "${targetSha}" may exist beyond the search window`, | ||
| { code: 'history_walk_limit_exceeded', field: 'sha' } | ||
| ); | ||
| } | ||
| throw new CmsValidationError( | ||
| `SHA "${targetSha}" is not in the history of article "${slug}"`, | ||
| { code: 'invalid_version_for_article', field: 'sha' } | ||
| ); | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Returns version history for an article by walking the parent chain. | ||
| * @param {{ slug: string, limit?: number }} options | ||
| * @returns {Promise<Array<{ sha: string, title: string, status: string, author: string, date: string }>>} | ||
| */ | ||
| async getArticleHistory({ slug, limit = 50 }) { | ||
| const canonicalSlug = canonicalizeSlug(slug); | ||
| const draftRef = this._refFor(canonicalSlug, 'articles'); | ||
| const pubRef = this._refFor(canonicalSlug, 'published'); | ||
| const sha = await this.graph.readRef(draftRef) || await this.graph.readRef(pubRef); | ||
|
|
||
| if (!sha) { | ||
| throw new CmsValidationError( | ||
| `Article not found: "${canonicalSlug}"`, | ||
| { code: 'article_not_found', field: 'slug' } | ||
| ); | ||
| } | ||
|
|
||
| const versions = []; | ||
| let current = sha; | ||
|
|
||
| while (current && versions.length < limit) { | ||
| const [info, message] = await Promise.all([ | ||
| this.graph.getNodeInfo(current), | ||
| this.graph.showNode(current), | ||
| ]); | ||
| const decoded = this.codec.decode(message); | ||
|
|
||
| versions.push({ | ||
| sha: current, | ||
| title: decoded.title, | ||
| status: decoded.trailers?.status || 'draft', | ||
| author: info.author, | ||
| date: info.date, | ||
| }); | ||
|
|
||
| current = info.parents?.[0] || null; | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| return versions; | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Reads full content of a specific commit by SHA. | ||
| * @param {{ slug: string, sha: string }} options | ||
| * @returns {Promise<{ sha: string, title: string, body: string, trailers: object }>} | ||
| */ | ||
| async readVersion({ slug, sha }) { | ||
| const canonicalSlug = canonicalizeSlug(slug); | ||
| const draftRef = this._refFor(canonicalSlug, 'articles'); | ||
| const tipSha = await this.graph.readRef(draftRef); | ||
|
|
||
| if (!tipSha) { | ||
| throw new CmsValidationError( | ||
| `Article not found: "${canonicalSlug}"`, | ||
| { code: 'article_not_found', field: 'slug' } | ||
| ); | ||
| } | ||
|
|
||
| // Ancestry validation: verify SHA belongs to this article's lineage | ||
| await this._validateAncestry(tipSha, sha, canonicalSlug); | ||
|
|
||
| const message = await this.graph.showNode(sha); | ||
| const decoded = this.codec.decode(message); | ||
|
Comment on lines
+413
to
+414
There was a problem hiding this comment.
Useful? React with 👍 / 👎. |
||
| return { sha, title: decoded.title, body: decoded.body, trailers: decoded.trailers }; | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Restores content from a historical SHA as a new draft commit. | ||
| * @param {{ slug: string, sha: string }} options | ||
| * @returns {Promise<{ ref: string, sha: string, prev: string }>} | ||
| */ | ||
| async restoreVersion({ slug, sha }) { | ||
| const canonicalSlug = canonicalizeSlug(slug); | ||
| const draftRef = this._refFor(canonicalSlug, 'articles'); | ||
|
|
||
| const { effectiveState, draftSha } = await this._resolveArticleState(canonicalSlug); | ||
| validateTransition(effectiveState, STATES.DRAFT); | ||
|
|
||
| if (!draftSha) { | ||
| throw new CmsValidationError( | ||
| `Cannot restore "${canonicalSlug}": no draft ref exists`, | ||
| { code: 'no_draft', field: 'slug' } | ||
| ); | ||
| } | ||
|
|
||
| // Ancestry validation: walk parent chain to verify target SHA belongs to this article | ||
| await this._validateAncestry(draftSha, sha, canonicalSlug); | ||
|
|
||
| // Read target SHA content | ||
| const targetMessage = await this.graph.showNode(sha); | ||
| const decoded = this.codec.decode(targetMessage); | ||
| const trailers = decoded.trailers || {}; | ||
| const { updatedat: _, restoredfromsha: _r, restoredat: _ra, ...restTrailers } = trailers; | ||
|
|
||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| const now = new Date().toISOString(); | ||
| const newMessage = this.codec.encode({ | ||
| title: decoded.title, | ||
| body: decoded.body, | ||
| trailers: { | ||
| ...restTrailers, | ||
| status: STATES.DRAFT, | ||
| updatedAt: now, | ||
| restoredFromSha: sha, | ||
| restoredAt: now, | ||
| }, | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| }); | ||
|
|
||
| const newSha = await this.graph.commitNode({ | ||
| message: newMessage, | ||
| parents: [draftSha], | ||
| sign: process.env.CMS_SIGN === '1', | ||
| }); | ||
|
|
||
| await this._updateRef({ ref: draftRef, newSha, oldSha: draftSha }); | ||
| return { ref: draftRef, sha: newSha, prev: draftSha }; | ||
| } | ||
|
|
||
| /** | ||
| * Uploads an asset and returns its manifest and CAS info. | ||
| */ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.