Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr Tile Sink #1446
Zarr Tile Sink #1446
Changes from 29 commits
0f537bb
5c6990b
29d8b19
599503f
10a1f7e
12946a0
f8fb42e
d697920
b50ecd9
f36f1a8
6b6a6a4
d6dd5ad
b7ed234
df8819f
0a832fd
cd0c715
41ea6b5
eaaf29e
0414f71
3da02f6
d0d6129
07e744f
5118fbc
e1e9831
6706f69
b58fcda
756502b
58897b3
a0b3fbc
f0e7482
5317daa
32c9c58
728faee
14bee28
ce1b1b7
5fac3a8
23b70f7
414ba67
f35d06e
157c731
62e6572
71d1068
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add
self._levels = []
here and a test that just doesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, added in 157c731
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to also delete the temporary file (or directory if we switch to it). If possible, it'd be nice to flag temp files/directories so they delete on close in general, so if the python process is killed or dies, the OS still cleans them up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be outdented (not in the
if axes[-1]
clause).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Moved in 62e6572
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurred to me this could be done without an explicit while loop. I think the equivalent would be:
I'm not sure that is clearer, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked ome zarr docs for version information. Are we more conformant to a dev version than the latest official version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following what I found here: https://ngff.openmicroscopy.org/latest/#multiscale-md, but I'm not entirely confident that this is all correct.