Update scikit-learn dependency to allow newer versions (Fixes #706) #709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: Fix scikit-learn dependency to allow newer versions
Description:
This pull request addresses the dependency issue related to
scikit-learn
that was identified in issue #706. The previous dependency specification requiredscikit-learn
to be exactly version1.3.2
. This restriction caused problems for users who had newer versions ofscikit-learn
installed, particularly for those using Python 3.12 and above, as it forced the installation of giotto-tda from source due to compatibility issues.Changes Made:
scikit-learn
in the project setup:This modification allows users to install giotto-tda without unnecessary complications and without the need to rely on building from source, significantly improving the installation process.
Impact:
scikit-learn
installed.Related Issue:
Please review the changes, and feel free to reach out if you have any questions or need further clarification on this update. Thank you for your attention to this matter!