fix: Remove deprecated http.CloseNotifier and replace with#4588
Open
JiwaniZakir wants to merge 2 commits intogin-gonic:masterfrom
Open
fix: Remove deprecated http.CloseNotifier and replace with#4588JiwaniZakir wants to merge 2 commits intogin-gonic:masterfrom
http.CloseNotifier and replace with#4588JiwaniZakir wants to merge 2 commits intogin-gonic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4586
Removes the deprecated
http.CloseNotifierinterface fromResponseWriterinresponse_writer.go, which was removed from Go's standard library and caused compilation warnings. TheStreamfunction incontext.gorelied onw.CloseNotify()to detect client disconnection, which no longer works with modern Go. Replaces the call withc.Request.Context().Done(), the idiomatic Go approach for detecting request cancellation. Verified by updatingresponse_writer_test.goto remove the now-invalid interface assertions and panic test.