fix(binding): handle non-JSON string values in form binding for custom struct types#4585
Open
mango766 wants to merge 1 commit intogin-gonic:masterfrom
Open
fix(binding): handle non-JSON string values in form binding for custom struct types#4585mango766 wants to merge 1 commit intogin-gonic:masterfrom
mango766 wants to merge 1 commit intogin-gonic:masterfrom
Conversation
…m struct types When a struct field implements json.Unmarshaler, form binding passes the raw form value directly to json.Unmarshal. Since form values are plain strings (e.g. "2020/09/23 13:20:49"), not valid JSON, the unmarshal fails. Fix this by retrying with the value wrapped in JSON quotes when the initial unmarshal fails. Fixes gin-gonic#2510
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4585 +/- ##
==========================================
- Coverage 99.21% 98.37% -0.84%
==========================================
Files 42 48 +6
Lines 3182 3145 -37
==========================================
- Hits 3157 3094 -63
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2510
When a struct field implements
json.Unmarshalerand is used with form binding (e.g.application/x-www-form-urlencoded), the form value is passed directly tojson.Unmarshal. Since form values are plain strings (like2020/09/23 13:20:49), not valid JSON, the unmarshal fails with an error likeinvalid character '/' after top-level value.This PR adds a fallback: if the initial
json.Unmarshalfails, it retries with the value wrapped in double quotes, treating it as a JSON string. This lets custom types implementingjson.Unmarshaler(e.g. custom datetime parsers) work correctly with form binding, while keeping existing JSON-based form values working as before.Changes
unmarshalFieldAsJSONhelper inbinding/form_mapping.gothat handles the quote-and-retry logicreflect.Structandreflect.Mapfallback paths insetWithProperTypejson.Unmarshalerstruct types with form bindingPull Request Checklist
masterbranch.docs/doc.md. (Not applicable — this is a bug fix)