Rename ko.po back to ko_KR.po#11074
Merged
jcollie merged 1 commit intoghostty-org:mainfrom Feb 28, 2026
Merged
Conversation
While it was renamed from ko_KR.UTF-8.po to ko.po in #10976, @uhojin, a Korean locale maintainer, notes [1] that “ko_KR [*South* Korean] makes more sense in locale context just to avoid any potential confusion between 한국어 vs 조선어”. Despite ko_KP (North Korean) not being present in glibc (as of version 2.43), and the ISO639 maintainers expressing disapproval of ko_KP [2], it is possible opinions may change in the future, and individual opinions may be contested—disambiguating doesn't hurt. [1]: #10976 (comment) [2]: #10976 (comment)
jcollie
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it was renamed from
ko_KR.UTF-8.potoko.poin #10976, @uhojin, a Korean locale maintainer, notes that “ko_KR [South Korean] makes more sense in locale context just to avoid any potential confusion between 한국어 vs 조선어”.Despite
ko_KP(North Korean) not being present in glibc (as of version 2.43), and the ISO639 maintainers expressing disapproval ofko_KP, it is possible opinions may change in the future, and individual opinions may be contested—disambiguating doesn't hurt.Requesting a review from all involved parties; I wish you all opine before merging.