More precise nostd lint

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez · Apr 10, 2024 · bb8c093 · bb8c093
1 parent c72cce2
commit bb8c093
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -0,0 +1,3 @@
+{
+	"rust-analyzer.showUnlinkedFileNotification": false
+}
diff --git a/src/cmd/lint/nostd.rs b/src/cmd/lint/nostd.rs
@@ -138,7 +138,7 @@ impl DefaultFeaturesDisabledCmd {
 		let ret = if content.contains("#![cfg_attr(not(feature = \"std\"), no_std)]") ||
 			content.contains("#![no_std]")
 		{
-			if content.contains("#![cfg(") {
+			if content.contains("\n#![cfg(") {
 				println!(
 					"{}: Crate may unexpectedly pull in libstd: {}",
 					g.yellow("WARN"),

diff --git a/tests/integration/sdk/nostd.yaml b/tests/integration/sdk/nostd.yaml
@@ -6,7 +6,6 @@ cases:
   stdout: |
     Default features not disabled for dependency: sp-core -> sp-externalities
     WARN: Crate may unexpectedly pull in libstd: frame-try-runtime
-    WARN: Crate may unexpectedly pull in libstd: frame-benchmarking
     Default features not disabled for dependency: sp-session -> sp-runtime
     Default features not disabled for dependency: sp-consensus-babe -> sp-timestamp
     WARN: Crate may unexpectedly pull in libstd: frame-system-benchmarking
@@ -41,7 +40,6 @@ cases:
   stdout: |
     Default features not disabled for dependency: sp-core -> sp-externalities
     WARN: Crate may unexpectedly pull in libstd: frame-try-runtime
-    WARN: Crate may unexpectedly pull in libstd: frame-benchmarking
     Default features not disabled for dependency: sp-session -> sp-runtime
     Default features not disabled for dependency: sp-consensus-babe -> sp-timestamp
     WARN: Crate may unexpectedly pull in libstd: frame-system-benchmarking