Skip to content

Commit

Permalink
Update signatures and baselines for metalava update
Browse files Browse the repository at this point in the history
Changes in metalava ab/7104465:7163804

Important ones:
- Fixed use of annotations from classpath
- Tracking default value for constructors
- New check for nullable collections

Relnote: N/A
Test: ./gradlew updateApi
Change-Id: Ia65aa2e56bdc0d743d8f445c6e8aa10811bed90e
Merged-In: Ia65aa2e56bdc0d743d8f445c6e8aa10811bed90e
  • Loading branch information
liutikas committed Feb 23, 2021
1 parent db16c52 commit d4a0b67
Show file tree
Hide file tree
Showing 162 changed files with 825 additions and 1,831 deletions.
10 changes: 0 additions & 10 deletions activity/activity/api/api_lint.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,6 @@ MissingGetterMatchingBuilder: androidx.activity.result.IntentSenderRequest.Build
androidx.activity.result.IntentSenderRequest does not declare a `getFlags()` method matching method androidx.activity.result.IntentSenderRequest.Builder.setFlags(int,int)


MissingNullability: androidx.activity.ComponentActivity#startActivityForResult(android.content.Intent, int) parameter #0:
Missing nullability on parameter `intent` in method `startActivityForResult`
MissingNullability: androidx.activity.ComponentActivity#startActivityForResult(android.content.Intent, int, android.os.Bundle) parameter #0:
Missing nullability on parameter `intent` in method `startActivityForResult`
MissingNullability: androidx.activity.ComponentActivity#startIntentSenderForResult(android.content.IntentSender, int, android.content.Intent, int, int, int) parameter #0:
Missing nullability on parameter `intent` in method `startIntentSenderForResult`
MissingNullability: androidx.activity.ComponentActivity#startIntentSenderForResult(android.content.IntentSender, int, android.content.Intent, int, int, int, android.os.Bundle) parameter #0:
Missing nullability on parameter `intent` in method `startIntentSenderForResult`


RegistrationName: androidx.activity.OnBackPressedDispatcher#addCallback(androidx.activity.OnBackPressedCallback):
Callback methods should be named register/unregister; was addCallback
RegistrationName: androidx.activity.OnBackPressedDispatcher#addCallback(androidx.lifecycle.LifecycleOwner, androidx.activity.OnBackPressedCallback):
Expand Down
3 changes: 0 additions & 3 deletions annotation/annotation-experimental/api/current.ignore

This file was deleted.

This file was deleted.

18 changes: 0 additions & 18 deletions appcompat/appcompat/api/api_lint.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -59,24 +59,12 @@ MissingBuildMethod: androidx.appcompat.app.AlertDialog.Builder:

MissingNullability: androidx.appcompat.app.ActionBar#addOnMenuVisibilityListener(androidx.appcompat.app.ActionBar.OnMenuVisibilityListener) parameter #0:
Missing nullability on parameter `listener` in method `addOnMenuVisibilityListener`
MissingNullability: androidx.appcompat.app.ActionBar#addTab(androidx.appcompat.app.ActionBar.Tab) parameter #0:
Missing nullability on parameter `tab` in method `addTab`
MissingNullability: androidx.appcompat.app.ActionBar#addTab(androidx.appcompat.app.ActionBar.Tab, boolean) parameter #0:
Missing nullability on parameter `tab` in method `addTab`
MissingNullability: androidx.appcompat.app.ActionBar#addTab(androidx.appcompat.app.ActionBar.Tab, int) parameter #0:
Missing nullability on parameter `tab` in method `addTab`
MissingNullability: androidx.appcompat.app.ActionBar#addTab(androidx.appcompat.app.ActionBar.Tab, int, boolean) parameter #0:
Missing nullability on parameter `tab` in method `addTab`
MissingNullability: androidx.appcompat.app.ActionBar#getCustomView():
Missing nullability on method `getCustomView` return
MissingNullability: androidx.appcompat.app.ActionBar#getThemedContext():
Missing nullability on method `getThemedContext` return
MissingNullability: androidx.appcompat.app.ActionBar#removeOnMenuVisibilityListener(androidx.appcompat.app.ActionBar.OnMenuVisibilityListener) parameter #0:
Missing nullability on parameter `listener` in method `removeOnMenuVisibilityListener`
MissingNullability: androidx.appcompat.app.ActionBar#removeTab(androidx.appcompat.app.ActionBar.Tab) parameter #0:
Missing nullability on parameter `tab` in method `removeTab`
MissingNullability: androidx.appcompat.app.ActionBar#selectTab(androidx.appcompat.app.ActionBar.Tab) parameter #0:
Missing nullability on parameter `tab` in method `selectTab`
MissingNullability: androidx.appcompat.app.ActionBar#setCustomView(android.view.View) parameter #0:
Missing nullability on parameter `view` in method `setCustomView`
MissingNullability: androidx.appcompat.app.ActionBar#setCustomView(android.view.View, androidx.appcompat.app.ActionBar.LayoutParams) parameter #0:
Expand All @@ -85,10 +73,6 @@ MissingNullability: androidx.appcompat.app.ActionBar#setCustomView(android.view.
Missing nullability on parameter `layoutParams` in method `setCustomView`
MissingNullability: androidx.appcompat.app.ActionBar#setIcon(android.graphics.drawable.Drawable) parameter #0:
Missing nullability on parameter `icon` in method `setIcon`
MissingNullability: androidx.appcompat.app.ActionBar#setListNavigationCallbacks(android.widget.SpinnerAdapter, androidx.appcompat.app.ActionBar.OnNavigationListener) parameter #0:
Missing nullability on parameter `adapter` in method `setListNavigationCallbacks`
MissingNullability: androidx.appcompat.app.ActionBar#setListNavigationCallbacks(android.widget.SpinnerAdapter, androidx.appcompat.app.ActionBar.OnNavigationListener) parameter #1:
Missing nullability on parameter `callback` in method `setListNavigationCallbacks`
MissingNullability: androidx.appcompat.app.ActionBar#setLogo(android.graphics.drawable.Drawable) parameter #0:
Missing nullability on parameter `logo` in method `setLogo`
MissingNullability: androidx.appcompat.app.ActionBar#setSplitBackgroundDrawable(android.graphics.drawable.Drawable) parameter #0:
Expand Down Expand Up @@ -415,8 +399,6 @@ MissingNullability: androidx.appcompat.app.AppCompatDelegate#addContentView(andr
Missing nullability on parameter `v` in method `addContentView`
MissingNullability: androidx.appcompat.app.AppCompatDelegate#addContentView(android.view.View, android.view.ViewGroup.LayoutParams) parameter #1:
Missing nullability on parameter `lp` in method `addContentView`
MissingNullability: androidx.appcompat.app.AppCompatDelegate#attachBaseContext(android.content.Context) parameter #0:
Missing nullability on parameter `context` in method `attachBaseContext`
MissingNullability: androidx.appcompat.app.AppCompatDelegate#createView(android.view.View, String, android.content.Context, android.util.AttributeSet):
Missing nullability on method `createView` return
MissingNullability: androidx.appcompat.app.AppCompatDelegate#createView(android.view.View, String, android.content.Context, android.util.AttributeSet) parameter #1:
Expand Down
13 changes: 0 additions & 13 deletions appcompat/appcompat/api/current.ignore

This file was deleted.

23 changes: 0 additions & 23 deletions appcompat/appcompat/api/restricted_current.ignore

This file was deleted.

5 changes: 5 additions & 0 deletions appsearch/appsearch/api/api_lint.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// Baseline format: 1.0
NullableCollection: androidx.appsearch.app.GenericDocument#getPropertyDocumentArray(String):
Return type of method androidx.appsearch.app.GenericDocument.getPropertyDocumentArray(String) is a nullable collection (`androidx.appsearch.app.GenericDocument[]`); must be non-null
NullableCollection: androidx.appsearch.app.GenericDocument#getPropertyStringArray(String):
Return type of method androidx.appsearch.app.GenericDocument.getPropertyStringArray(String) is a nullable collection (`java.lang.String[]`); must be non-null
3 changes: 1 addition & 2 deletions benchmark/common/api/public_plus_experimental_current.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ package androidx.benchmark {
}

@RestrictTo(androidx.annotation.RestrictTo.Scope.LIBRARY_GROUP) public final class InstrumentationResultScope {
ctor public InstrumentationResultScope(android.os.Bundle bundle);
ctor public InstrumentationResultScope();
ctor public InstrumentationResultScope(optional android.os.Bundle bundle);
method public void fileRecord(String key, String path);
method public android.os.Bundle getBundle();
method public void ideSummaryRecord(String value);
Expand Down
32 changes: 32 additions & 0 deletions browser/browser/api/api_lint.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,38 @@ MissingGetterMatchingBuilder: androidx.browser.trusted.TrustedWebActivityIntentB
androidx.browser.trusted.TrustedWebActivityIntent does not declare a `getSplashScreenParams()` method matching method androidx.browser.trusted.TrustedWebActivityIntentBuilder.setSplashScreenParams(android.os.Bundle)


NullableCollection: androidx.browser.customtabs.CustomTabsCallback#extraCallback(String, android.os.Bundle) parameter #1:
Type of parameter args in androidx.browser.customtabs.CustomTabsCallback.extraCallback(String callbackName, android.os.Bundle args) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsCallback#extraCallbackWithResult(String, android.os.Bundle):
Return type of method androidx.browser.customtabs.CustomTabsCallback.extraCallbackWithResult(String,android.os.Bundle) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsCallback#extraCallbackWithResult(String, android.os.Bundle) parameter #1:
Type of parameter args in androidx.browser.customtabs.CustomTabsCallback.extraCallbackWithResult(String callbackName, android.os.Bundle args) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsCallback#onMessageChannelReady(android.os.Bundle) parameter #0:
Type of parameter extras in androidx.browser.customtabs.CustomTabsCallback.onMessageChannelReady(android.os.Bundle extras) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsCallback#onNavigationEvent(int, android.os.Bundle) parameter #1:
Type of parameter extras in androidx.browser.customtabs.CustomTabsCallback.onNavigationEvent(int navigationEvent, android.os.Bundle extras) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsCallback#onPostMessage(String, android.os.Bundle) parameter #1:
Type of parameter extras in androidx.browser.customtabs.CustomTabsCallback.onPostMessage(String message, android.os.Bundle extras) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsCallback#onRelationshipValidationResult(int, android.net.Uri, boolean, android.os.Bundle) parameter #3:
Type of parameter extras in androidx.browser.customtabs.CustomTabsCallback.onRelationshipValidationResult(int relation, android.net.Uri requestedOrigin, boolean result, android.os.Bundle extras) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsClient#extraCommand(String, android.os.Bundle):
Return type of method androidx.browser.customtabs.CustomTabsClient.extraCommand(String,android.os.Bundle) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsIntent#startAnimationBundle:
Type of field androidx.browser.customtabs.CustomTabsIntent.startAnimationBundle is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.customtabs.CustomTabsService#extraCommand(String, android.os.Bundle):
Return type of method androidx.browser.customtabs.CustomTabsService.extraCommand(String,android.os.Bundle) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.trusted.TrustedWebActivityCallback#onExtraCallback(String, android.os.Bundle) parameter #1:
Type of parameter args in androidx.browser.trusted.TrustedWebActivityCallback.onExtraCallback(String callbackName, android.os.Bundle args) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.trusted.TrustedWebActivityService#onExtraCommand(String, android.os.Bundle, androidx.browser.trusted.TrustedWebActivityCallbackRemote):
Return type of method androidx.browser.trusted.TrustedWebActivityService.onExtraCommand(String,android.os.Bundle,androidx.browser.trusted.TrustedWebActivityCallbackRemote) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.trusted.TrustedWebActivityServiceConnection#sendExtraCommand(String, android.os.Bundle, androidx.browser.trusted.TrustedWebActivityCallback):
Return type of method androidx.browser.trusted.TrustedWebActivityServiceConnection.sendExtraCommand(String,android.os.Bundle,androidx.browser.trusted.TrustedWebActivityCallback) is a nullable collection (`android.os.Bundle`); must be non-null
NullableCollection: androidx.browser.trusted.sharing.ShareData#uris:
Type of field androidx.browser.trusted.sharing.ShareData.uris is a nullable collection (`java.util.List`); must be non-null
NullableCollection: androidx.browser.trusted.sharing.ShareTarget.Params#files:
Type of field androidx.browser.trusted.sharing.ShareTarget.Params.files is a nullable collection (`java.util.List`); must be non-null


OptionalBuilderConstructorArgument: androidx.browser.customtabs.CustomTabsIntent.Builder#Builder(androidx.browser.customtabs.CustomTabsSession) parameter #0:
Builder constructor arguments must be mandatory (i.e. not @Nullable): parameter session in androidx.browser.customtabs.CustomTabsIntent.Builder(androidx.browser.customtabs.CustomTabsSession session)

Expand Down
3 changes: 0 additions & 3 deletions camera/camera-core/api/current.ignore

This file was deleted.

3 changes: 0 additions & 3 deletions camera/camera-core/api/restricted_current.ignore

This file was deleted.

2 changes: 0 additions & 2 deletions camera/camera-view/api/current.txt
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ package androidx.camera.view {
method public androidx.lifecycle.LiveData<androidx.camera.view.PreviewView.StreamState!> getPreviewStreamState();
method @UiThread public androidx.camera.view.PreviewView.ScaleType getScaleType();
method @UiThread public androidx.camera.core.Preview.SurfaceProvider getSurfaceProvider();
method @UiThread public androidx.camera.core.ViewPort? getViewPort();
method @UiThread public androidx.camera.core.ViewPort? getViewPort(int);
method @UiThread public void setController(androidx.camera.view.CameraController?);
method @UiThread public void setImplementationMode(androidx.camera.view.PreviewView.ImplementationMode);
method @UiThread public void setScaleType(androidx.camera.view.PreviewView.ScaleType);
Expand Down
2 changes: 0 additions & 2 deletions camera/camera-view/api/restricted_current.txt
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ package androidx.camera.view {
method public androidx.lifecycle.LiveData<androidx.camera.view.PreviewView.StreamState!> getPreviewStreamState();
method @UiThread public androidx.camera.view.PreviewView.ScaleType getScaleType();
method @UiThread public androidx.camera.core.Preview.SurfaceProvider getSurfaceProvider();
method @UiThread public androidx.camera.core.ViewPort? getViewPort();
method @UiThread public androidx.camera.core.ViewPort? getViewPort(@androidx.camera.core.impl.ImageOutputConfig.RotationValue int);
method @UiThread public void setController(androidx.camera.view.CameraController?);
method @UiThread public void setImplementationMode(androidx.camera.view.PreviewView.ImplementationMode);
method @UiThread public void setScaleType(androidx.camera.view.PreviewView.ScaleType);
Expand Down
Loading

0 comments on commit d4a0b67

Please sign in to comment.