Fix up CreateTextureViewError::TooMany{MipLevels,ArrayLayers} crashes and style
#8808
+21
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Regressed by #8323, which I reviewed. 😅
Description
These error variants use a naive
base + offsetfrom user-provided input in order to be diagnostically helpful inDisplay. Eek! Add aBasePlusOffsetstructure that can be safely used to show calculations like this, falling back to displaying<overflow>if it doesn't work, and use that instead of the naive addition.Also, fix up some styling stuff that I noticed was wrong and/or not consistent with other parts of code. See individual commits for more details.
Testing
TBD. I'd like to see a CTS test for this, since this is prime validation coverage that doesn't appear to be tested.
Squash or Rebase?
rebase plz
Checklist
CHANGELOG.mdentry.