Skip to content

Conversation

@cwfitzgerald
Copy link
Member

This fixes three issues with lazy jobs:

  • Build issues with the publishing job
  • A very old way of getting the vulkan sdk on the spirv samples job.
  • This switches them to always run on every PR, but be optional (and only actually publish on trunk).

Publishing can only actually happen if secrets are available, and secrets are not accessible to PRs.

Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeet

@ErichDonGubler ErichDonGubler merged commit 3ce7366 into gfx-rs:trunk Jan 5, 2026
52 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/lazy-fixes branch January 5, 2026 23:03
0323pin pushed a commit to 0323pin/wgpu that referenced this pull request Jan 6, 2026
* Always run lazy jobs

* Fix lazy spirv job

* Fix publishing build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants