Skip to content

[player] Support specifying a trace file directly #7982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

andyleiserson
Copy link
Contributor

Also provide a default initialization if the trace does not contain one.

Useful for working with fuzzing traces.

I also have some local changes for putting buffer/texture/shader data inline in the trace, but it would need some backwards compatibility logic to load existing traces before that could be merged.

Testing
Passes existing player tests, and tested playback from a file manually.

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson requested a review from a team as a code owner July 21, 2025 18:40
Also provide a default initialization if the trace does not contain one.
@cwfitzgerald
Copy link
Member

but it would need some backwards compatibility logic to load existing traces before that could be merged.

I don't think there's have that much interest in preserving backwards compat for traces

@andyleiserson andyleiserson merged commit 4a00b62 into gfx-rs:trunk Jul 22, 2025
40 checks passed
@andyleiserson andyleiserson deleted the trace-file branch July 22, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants