Fix empty ifs causing errors on spirv 1.6
#7883
Open
+309
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vecvec
force-pushed
the
branch_same
branch
2 times, most recently
from
6f1f6b1 to
fd64b3a
Compare
ErichDonGubler
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
I tried force-pushing to resolve conflicts with the tip set to efe59c0, but I'm getting denied by GitHub. Not sure why, but LGTM otherwise!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #7882
Description
Skips
ifstatements if both the accept and reject blocks are empty, they don't do anything so we can just not write them out.Testing
Adds a snapshot test.
Squash or Rebase?
Squash.
Checklist
cargo fmt.taplo format.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.