Skip to content

[wgpu-hal]: MVP no_std support #7599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

bushrat011899
Copy link
Contributor

@bushrat011899 bushrat011899 commented Apr 23, 2025

Connections

Description

  • Disable default features from wgpu-types when used as a workspace dependency, and then re-enable in affected crates.
  • Add wgpu-hal to the no_std CI task.
  • Feature gate usage of parking_lot in wgpu-hal to only the features that actually use it.
  • Add new feature to wgpu-hal, validation_canary, which controls the compilation of the VALIDATION_CANARY static, and only enable it in wgpu-tests. This was the only unconditional use of parking_lot in wgpu-hal, and since it's an internal debugging feature, I believe it makes sense to feature-gate it as such.

Testing

  • CI

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@bushrat011899 bushrat011899 requested review from crowlKats and a team as code owners April 23, 2025 03:44
@bushrat011899
Copy link
Contributor Author

CI / Clippy WASM Core 1.0 is an expected failure while #7585 is not merged.

@cwfitzgerald cwfitzgerald self-assigned this Apr 23, 2025
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor things, but g2g after those :)

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button :)

@bushrat011899
Copy link
Contributor Author

Should be good to go now!

@cwfitzgerald
Copy link
Member

Could you do that transform on the other backends which have a validation canary, as well - forgot to note them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants