Skip to content

[naga]: Remove unused features from petgraph #7591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

bushrat011899
Copy link
Contributor

Connections

Description

  • Remove unused features from petgraph in Naga, improving no_std compatibility

Testing

  • CI

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt. N/A
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry. N/A

@bushrat011899 bushrat011899 requested a review from a team as a code owner April 22, 2025 10:11
@bushrat011899
Copy link
Contributor Author

I believe this CI failure is spurious.

@ErichDonGubler ErichDonGubler self-assigned this Apr 22, 2025
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but there's a blocking concern with the choice of hasher I want to validate first.

@ErichDonGubler ErichDonGubler enabled auto-merge (squash) April 23, 2025 03:18
@ErichDonGubler ErichDonGubler merged commit 35f131f into gfx-rs:trunk Apr 23, 2025
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants