Upgrade CORE_MSRV to 1.82 and take advantage of some new features
#7043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
area: infrastructure
This was previously an `allow`-by-default warning in Clippy's `pedantic` group, but with Rust 1.83 it was promoted to a `warn`-by-default member of its `complexity` group.
`std::mem::{size,align}_of{,_val}` was added to `std::prelude` in Rust
1.80; see
[`rust`#123168](rust-lang/rust#123168).
ErichDonGubler
force-pushed
the
rust-lints-with-1.82
branch
2 times, most recently
from
cf11a20 to
50acbf9
Compare
Weaken our dependence on the `once_cell` crate by using functionality from `std` instead that was upstreamed from `once_cell`, this time with what's available in Rust 1.80+. It's not yet possible to eliminate this dependency entirely, but do what we can for now.
ErichDonGubler
force-pushed
the
rust-lints-with-1.82
branch
from
50acbf9 to
1dd9e4f
Compare
cwfitzgerald
requested changes
Jan 31, 2025
ErichDonGubler
force-pushed
the
rust-lints-with-1.82
branch
from
1dd9e4f to
c3372d4
Compare
ErichDonGubler
force-pushed
the
rust-lints-with-1.82
branch
3 times, most recently
from
ae62dc7 to
d4b6538
Compare
👍🏻 AFAIK, I've taken care of all of these. The |
|
Gonna demote to a draft, while I figure out how to get crap compiling. |
ErichDonGubler
force-pushed
the
rust-lints-with-1.82
branch
2 times, most recently
from
71f9c77 to
451e815
Compare
ErichDonGubler
force-pushed
the
rust-lints-with-1.82
branch
from
451e815 to
d0c2207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
With patches for bug 1945020 landing against
mozilla-central, we should be ready to bumpCORE_MSRVto Rust 1.82. Woot! 🙌🏻Description
Title says all. 💪
Testing
CI and done.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.