Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid default features in many dependencies (etc.) #7031

Conversation

brody4hire
Copy link
Contributor

@brody4hire brody4hire commented Jan 30, 2025

Connections

Some of these dependency updates are needed for no-std support:

I think making the dependency updates in this isolated PR can help keep the no-std updates cleaner & more focused.

Description

  • use default-features = false for more dependencies in top-level Cargo.toml
  • only use strum for wgsl-in in naga crate
  • move some dependencies in top-level Cargo.toml

Testing

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Cargo.toml Outdated Show resolved Hide resolved
@brody4hire brody4hire marked this pull request as ready for review January 30, 2025 06:38
@brody4hire brody4hire requested a review from a team as a code owner January 30, 2025 06:38
@brody4hire brody4hire marked this pull request as draft January 30, 2025 08:37
brody4hire

This comment was marked as resolved.

Cargo.toml Outdated Show resolved Hide resolved
@brody4hire brody4hire mentioned this pull request Jan 30, 2025
2 tasks
@brody4hire brody4hire changed the title avoid default features in many dependencies, etc. avoid default features in many dependencies (etc.) Jan 30, 2025
@brody4hire brody4hire force-pushed the avoid-default-features-in-many-dependencies-etc branch from fb6bade to fa85d46 Compare January 30, 2025 10:10
@brody4hire brody4hire marked this pull request as ready for review January 30, 2025 10:10
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 😀

@ErichDonGubler ErichDonGubler merged commit a8cc83e into gfx-rs:trunk Jan 30, 2025
31 checks passed
@brody4hire brody4hire deleted the avoid-default-features-in-many-dependencies-etc branch January 30, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants