-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-std support in naga #6940
Draft
brody4hire
wants to merge
21
commits into
gfx-rs:trunk
Choose a base branch
from
brody4hire:no-std-support-in-naga
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
no-std support in naga #6940
+310
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c/proc/constant_evaluator.rs
…h clippy warnings
This was referenced Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
issue(s):
recommended pre-requisite(s):
hashbrown
innaga
& mainwgpu
crates, etc. #6938blocking other proposal(s):
wgpu-core
- PR no-std support in wgpu-core #6926Description
I think this should be the beginning of adding no-std support to the
wgpu
crates.This proposal enables build & usage of
naga
withno_std
. New "std" option is added & enabled by default.All existing options require "std" feature to build. TODO item is to support as many features as possible with no-std. I may want to defer these updates to a future PR.
There are quite a few loose ends, mostly marked by XXX todo comments, I hope to make some progress resolving these over the weekend.
/cc @bushrat011899
Testing
cargo test --no-default-features -p naga
cargo test --all-features -p naga
cargo xtask test
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.