fix(core): validate dst_buffer isn't destroyed when resolving query sets
#6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
type: bug
ErichDonGubler
changed the title
dst_buffer isn't destroyed when resolving query…dst_buffer isn't destroyed when resolving query sets
ErichDonGubler
force-pushed
the
no-destroyed-buf-in-query-set-resolution-plz
branch
2 times, most recently
from
c70f54c to
158515f
Compare
teoxoy
approved these changes
Nov 21, 2024
…validation in pass creation
…mpute,render}_pass`
ErichDonGubler
force-pushed
the
no-destroyed-buf-in-query-set-resolution-plz
branch
from
158515f to
6365e2d
Compare
7 tasks
ErichDonGubler
deleted the
no-destroyed-buf-in-query-set-resolution-plz
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
We should be checking that the buffer query that query sets will be resolved into are, in fact, not destroyed. Do it!
Testing
webgpu:api,validation,encoding,beginComputePass:timestampWrites,invalid_query_set:querySetState="invalid"Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.