Upgrade to latest wgpu #441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
23.0 is out, so the git hashes can be a proper version again :) |
|
Quick request. I see you've added ComputePassSetPushConstants. Would it be difficult to also add RenderEncoderSetPutConstants. Not that I need it, but it seems that if we have two. we should have the complete set. Thanks |
Done!
Not the point of this PR, which only mechanically upgrade the underlying wgpu, you should open a dedicated issue ;) |
|
I was about to send you an email to cancel that previous request. It
turns out that RenderBundleSetPushConstants is completely broken, and has
probably never been used. I'm in the middle of creating a bug report.
…On Mon, Nov 11, 2024 at 11:44 PM Elie Michel ***@***.***> wrote:
23.0 is out, so the git hashes can be a proper version again :)
Done!
Quick request. I see you've added ComputePassSetPushConstants.
Not the point of this PR, which only mechanically upgrade the underlying
wgpu, you should open a dedicated issue ;)
—
Reply to this email directly, view it on GitHub
<#441 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC2LIP265GQH5RJKW23R3L2AGWVHAVCNFSM6AAAAABP33FGCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZHAYDQNJUGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
almarklein
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
This looks good to me. @rajveermalviya do you have time to review this too? I'm not confident enough with Rust to judge most changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #427 and adapts it to recent changes in
wgpu.My overall goal is to adapt to gfx-rs/wgpu#6360 so that we can finally implement
WGPUFuture.