vcr-clj.core/with-cassette supports :arg-transformer option #22
+61
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfredericks
requested changes
Apr 16, 2017
src/vcr_clj/core.clj
Outdated
| arguments to the function call are passed through this | ||
| transformer, and the transformed arguments are passed | ||
| to arg-key-fn, recordable? and the recorded function. | ||
| Defaults to clojure.core/identity. |
There was a problem hiding this comment.
should identity be vector here?
There was a problem hiding this comment.
Oops. I'll change the docstring.
| @@ -87,6 +88,27 @@ | |||
| :arg-key-fn #(mod % 2)}] | |||
| (is (= 42 (increment 29))))) | |||
|
|
|||
| (deftest arg-transformer-test | |||
| (with-spy [put-foo] | |||
| (with-cassette :shebang | |||
chairmank
force-pushed
the
arg-transformer
branch
from
070241b to
60c3b31
Compare
|
I rebased on the current HEAD of master branch and fixed the mistake in the docstring. |
I added a new `:arg-transformer` option that is analogous to the existing `:return-transformer` option. During both recording and playback, the original arguments are intercepted and replaced by `(apply return-transformer args)`, and these transformed arguments are passed to `arg-key-fn`, `recordable?`, and the recorded function. This feature is intended to enable serialization of HTTP request bodies for gfredericks#17
chairmank
force-pushed
the
arg-transformer
branch
from
60c3b31 to
50228b7
Compare
|
Released as 0.4.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new
:arg-transformeroption that is analogous to the existing:return-transformeroption. During both recording and playback, the originalarguments are interepted and replaced by
(apply return-transformer args), andthese transformed arguments are passed to
arg-key-fn,recordable?, and therecorded function.
This feature is intended to enable serialization of HTTP request bodies for
#17