fix(mcp): route FalkorDB UUID operations to tenant graphs - #1765
Open
noamsiegel wants to merge 2 commits into
Open
fix(mcp): route FalkorDB UUID operations to tenant graphs#1765noamsiegel wants to merge 2 commits into
noamsiegel wants to merge 2 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: noam@noamsiegel.com |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FalkorDriver.clone()index-build side effects during reads.Graphiti.add_episode()mutates the shared driver binding.Problem
FalkorDB stores each
group_idas a physical graph. The remaining UUID-keyed MCP handlers bypass group-aware routing and query whichever graph the shared driver currently targets. Concurrent per-group queue workers can also race whileGraphiti.add_episode()rebinds that shared driver. Both cases can report missing data or operate on the wrong tenant graph.get_episodesis intentionally not changed here because currentmainalready routesEpisodicNode.get_by_group_idsthrough the merged FalkorDB operations fix.Fixes #1651.
Verification
python -m pytest -q tests/test_falkor_routing.py tests/test_core_parity.py- 34 passed.python -m ruff format --check ...andpython -m ruff check ...- clean.python -m pyright --pythonpath <venv-python> src/utils/falkor_routing.py src/graphiti_mcp_server.py src/services/queue_service.py- 0 errors.