added gemini 3.1 models to gemini_client.py#1309
added gemini 3.1 models to gemini_client.py#1309jawherkh wants to merge 1 commit intogetzep:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 174949b9ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if 'graph_driver' not in item.fixturenames: | ||
| continue | ||
| if item.get_closest_marker('integration') is not None: | ||
| continue | ||
| item.add_marker(integration_marker) |
There was a problem hiding this comment.
This unconditional graph_driver→integration remapping changes marker semantics for every pytest invocation, not just make test. In .github/workflows/unit_tests.yml, the database-integration-tests job runs pytest ... -m "not integration" against tests/test_graphiti_mock.py, tests/test_node_int.py, and tests/test_edge_int.py, and those tests all use the graph_driver fixture, so they are now deselected instead of executed. That silently removes most DB integration coverage from CI.
Useful? React with 👍 / 👎.
|
I have read the CLA Document and I hereby sign the CLA |
2 participants
Summary
This PR adds Gemini 3.1 preview model support to the Gemini client by registering the new model names in the max-token map. It also includes a small pytest discovery fix so
make testonly targets the root test suite and automatically treatsgraph_driver-based tests as integration tests, preventing local Neo4j credential state from breaking the non-integration test target. The remaining code changes are formatting-only cleanups in a few files.Type of Change
Objective
Add support for newer Gemini 3.1 preview models so the client can apply the correct output token limits when those models are configured. While validating the change, the root test target exposed pytest collection issues in the multi-project repo layout, so this PR also tightens root test discovery and integration test classification to keep
make testaligned with its intended non-integration scope.Testing
Tested with:
make testResult:
263 passed, 1 skipped, 51 deselectedBreaking Changes
If this is a breaking change, describe:
Checklist
make lintpasses)