-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: publish vroom to GHCR and provide a tagged release on GHCR #576
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/ci.yaml
Outdated
- timeout-minutes: 20 | ||
run: until docker pull "us-central1-docker.pkg.dev/sentryio/vroom/vroom:${{ github.sha }}" 2>/dev/null; do sleep 10; done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's definitely not do this and move the actual build to GitHub Actions. Otherwise you are just wasting CPU cycles and holding up workers until the Google build is done.
Alternatively, you can just another target in .craft.yml
which does exactly what you do here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess? :D
Ah, the failure was due to permissions. Retried from my account, let's see if it goes through. |
@BYK I believe it was due to this https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#pushing-container-images
|
Similar work with these PRs:
While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.