Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish vroom to GHCR and provide a tagged release on GHCR #576

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Mar 28, 2025

Similar work with these PRs:

While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505 aldy505 requested a review from a team as a code owner March 28, 2025 03:07
Comment on lines 58 to 59
- timeout-minutes: 20
run: until docker pull "us-central1-docker.pkg.dev/sentryio/vroom/vroom:${{ github.sha }}" 2>/dev/null; do sleep 10; done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's definitely not do this and move the actual build to GitHub Actions. Otherwise you are just wasting CPU cycles and holding up workers until the Google build is done.

Alternatively, you can just another target in .craft.yml which does exactly what you do here.

@aldy505 aldy505 requested a review from BYK March 29, 2025 05:11
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess? :D

@BYK
Copy link
Member

BYK commented Mar 31, 2025

@asottile-sentry for the review, especially on required checks.

Ah, the failure was due to permissions. Retried from my account, let's see if it goes through.

@aldy505
Copy link
Contributor Author

aldy505 commented Mar 31, 2025

@asottile-sentry for the review, especially on required checks.

Ah, the failure was due to permissions. Retried from my account, let's see if it goes through.

@BYK I believe it was due to this https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#pushing-container-images

When you first publish a package, the default visibility is private. To change the visibility or set access permissions, see Configuring a package's access control and visibility. You can link a published package to a repository using the user interface or command line. For more information, see Connecting a repository to a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants