Replace DATETIME columns with INTEGER #131
Open
+24
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQlite doesn't have a specific storage type for datetime values and uses TEXT instead. This requires careful use of `datetime()` functions on value. By switching to INTEGER columns we won't get burned by future changes to datetime logic if we forget a function. It should also result in smaller database sizes. I've also made `remove_at` required as we should not store an activation that cannot be purged in the future. Fixes #111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQlite doesn't have a specific storage type for datetime values and uses TEXT instead. This requires careful use of
datetime()functions on value. By switching to INTEGER columns we won't get burned by future changes to datetime logic if we forget a function. It should also result in smaller database sizes. sqlx includes trait implementations to convertDateTime<Utc>into a timestamp already and from a timestamp intoDateTime<Utc>.I've also made
remove_atrequired as we should not store an activation that cannot be purged in the future.Fixes #111