Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed missing underscore #83153

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fixed missing underscore #83153

merged 1 commit into from
Jan 14, 2025

Conversation

bitsandfoxes
Copy link
Contributor

Resolves getsentry/sentry-unreal#256

Since we're checking for crash_type

sentry/src/sentry/rules/conditions/event_attribute.py

Line 393 in c11f4c0

if path[1] == "crash_type":
this seems to be a typo.

@bitsandfoxes bitsandfoxes requested a review from a team as a code owner January 9, 2025 09:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
@bitsandfoxes bitsandfoxes merged commit f5d6888 into master Jan 14, 2025
49 of 50 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/unreal-crash_type branch January 14, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obostjancic obostjancic obostjancic approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert filter unreal.crashtype not respected in alert rules
2 participants
@bitsandfoxes @obostjancic