motion: add first class framer support #102531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Nov 1, 2025
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
LGTM! I'll tinker with the the animation next week, but my guess is:
- We'll need to adjust the current durations and space them out (e.g., I'd expect a "slow" animation that covers a lot of the screen to be in the 300-500ms range)
- We might need to introduce more sophisticated animation tokens that are physics-based, to support the current modals
In any case, I'll let you know once I try it out. Thanks for putting this together!
P.S. Maybe a little surprising that "framer" is nested at the same level as "slow" under theme.motion but TBH I was about to do the same thing
Member
Author
I could do something like add use String() object and then add a .framer property via proxy. That way I we could define |
Member
|
@JonasBa 🤔 I leave it to you! IMO it's fine as-is, too! Good to keep things simple |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102531 +/- ##
===========================================
- Coverage 80.99% 80.88% -0.11%
===========================================
Files 8865 8860 -5
Lines 392651 390421 -2230
Branches 24834 24832 -2
===========================================
- Hits 318015 315786 -2229
+ Misses 74271 74270 -1
Partials 365 365 |
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
Add first class framer motion support to theme. @gggritso I'll let you experiment with the transition definition for the drawer animation and we'll figure out if we can modify one of our current definitions or introduce a brand new one, but I'd like to defer that until we see what the desired transition would look like.
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
Add first class framer motion support to theme. @gggritso I'll let you experiment with the transition definition for the drawer animation and we'll figure out if we can modify one of our current definitions or introduce a brand new one, but I'd like to defer that until we see what the desired transition would look like.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Add first class framer motion support to theme. @gggritso I'll let you experiment with the transition definition for the drawer animation and we'll figure out if we can modify one of our current definitions or introduce a brand new one, but I'd like to defer that until we see what the desired transition would look like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add first class framer motion support to theme.
@gggritso I'll let you experiment with the transition definition for the drawer animation and we'll figure out if we can modify one of our current definitions or introduce a brand new one, but I'd like to defer that until we see what the desired transition would look like.