chore(commits): Delete unused dual write commit tables #102506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
force-pushed
the
danf/commit-remove-dual-write-tables
branch
from
2822b79 to
2642a0b
Compare
Base automatically changed from
danf/commit-remove-dual-write-tables
to
master
October 31, 2025 21:52
Follow up migration to delete these from the database.
wedamija
force-pushed
the
danf/commit-delete-dual-write-tables
branch
from
f81980f to
55288c1
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Delete model Commit
--
DROP TABLE "releases_commit" CASCADE;
--
-- Delete model CommitFileChange
--
DROP TABLE "releases_commitfilechange" CASCADE; |
armenzg
reviewed
Nov 5, 2025
|
|
||
| operations = [ | ||
| SafeDeleteModel(name="Commit", deletion_action=DeletionAction.DELETE), | ||
| SafeDeleteModel(name="CommitFileChange", deletion_action=DeletionAction.DELETE), |
There was a problem hiding this comment.
@wedamija Do you want DeletionAction.MOVE_TO_PENDING first?
There was a problem hiding this comment.
Already handled in 0002. Also, jfyi, ci will complain if someone attempts to delete before doing MOVE_TO_PENDING first
armenzg
approved these changes
Nov 5, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
Follow up migration to delete these from the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up migration to delete these from the database. Leaving this in draft until the code removal deploys