Skip to content

Conversation

@armenzg
Copy link
Member

@armenzg armenzg commented Oct 31, 2025

This was removed in #102354 during an incident but #102369 has been merged since then.

It seems it broke because of this: getsentry/snuba#7447

This was removed in #102354 during an incident but Dan's change has been merged since then.
@codecov
Copy link

codecov bot commented Oct 31, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
29532 1 29531 242
View the top 1 failed test(s) by shortest run time
tests.sentry.deletions.test_group.DeleteIssuePlatformTest::test_simple_issue_platform
Stack Traces | 50.1s run time
#x1B[1m#x1B[.../sentry/deletions/test_group.py#x1B[0m:501: in test_simple_issue_platform
    raise AssertionError(
#x1B[1m#x1B[31mE   AssertionError: Issue platform events not deleted from Snuba after ~6.5 seconds. Found: {'event_id': 'e31972dabe2c4f14908a451f29aca4a0', 'group_id': 31, 'occurrence_id': 'eac3559ad7ee442dab7f00204b81bd94'}#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Group Type Mismatch in Test Data Initialization

The test is incorrectly setting type=GroupCategory.FEEDBACK (value 6) when it should be setting type=FeedbackGroup.type_id (value 6001). The type field on a Group should store a GroupType.type_id, not a GroupCategory value. This is inconsistent with how the field is used elsewhere in the test (e.g., line 404) and in other tests throughout the codebase.

tests/sentry/deletions/test_group.py#L481-L485

# Set times_seen for each group
Group.objects.filter(id=group1.id).update(times_seen=3, type=GroupCategory.FEEDBACK)
Group.objects.filter(id=group2.id).update(times_seen=1, type=GroupCategory.FEEDBACK)
Group.objects.filter(id=group3.id).update(times_seen=3, type=GroupCategory.FEEDBACK)
Group.objects.filter(id=group4.id).update(times_seen=3, type=GroupCategory.FEEDBACK)

Fix in Cursor Fix in Web


This sacrifices the tests simulation in favor of predictibale results and less flakiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants