-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
tests(deletions): Add removed test #102503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This was removed in #102354 during an incident but Dan's change has been merged since then.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ba406bc to
d89a987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Group Type Mismatch in Test Data Initialization
The test is incorrectly setting type=GroupCategory.FEEDBACK (value 6) when it should be setting type=FeedbackGroup.type_id (value 6001). The type field on a Group should store a GroupType.type_id, not a GroupCategory value. This is inconsistent with how the field is used elsewhere in the test (e.g., line 404) and in other tests throughout the codebase.
tests/sentry/deletions/test_group.py#L481-L485
sentry/tests/sentry/deletions/test_group.py
Lines 481 to 485 in d89a987
| # Set times_seen for each group | |
| Group.objects.filter(id=group1.id).update(times_seen=3, type=GroupCategory.FEEDBACK) | |
| Group.objects.filter(id=group2.id).update(times_seen=1, type=GroupCategory.FEEDBACK) | |
| Group.objects.filter(id=group3.id).update(times_seen=3, type=GroupCategory.FEEDBACK) | |
| Group.objects.filter(id=group4.id).update(times_seen=3, type=GroupCategory.FEEDBACK) |
This sacrifices the tests simulation in favor of predictibale results and less flakiness
d89a987 to
e727caa
Compare
4335498 to
377d477
Compare
This was removed in #102354 during an incident but #102369 has been merged since then.
It seems it broke because of this: getsentry/snuba#7447