Skip to content

Conversation

@natemoo-re
Copy link
Member

Before #101654 introduces a new loader, we should eliminate the loader waterfall and layout thrash we currently have.

The flow currently is

After this PR, the flow remains the same except for the final step. Instead of the <OrganizationLoadingIndicator /> rendering a new component, we grab the innerHTML of the initial "splash screen" loader. React will recognize that the VDOM matches the existing DOM and avoid reconciliation, preserving the state of our existing SSR loader (animations, messages, and all).

@natemoo-re natemoo-re requested review from a team and evanpurkhiser October 23, 2025 18:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 23, 2025
@natemoo-re natemoo-re force-pushed the fix/organization-loader branch from 2da1bce to 16b5071 Compare October 23, 2025 20:40
@natemoo-re natemoo-re enabled auto-merge (squash) October 23, 2025 20:41
@natemoo-re natemoo-re merged commit 5dc1cd6 into master Oct 23, 2025
46 checks passed
@natemoo-re natemoo-re deleted the fix/organization-loader branch October 23, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants