ref(ux): reuse django rendered loader for org #102030
Merged
+20
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #101654 introduces a new loader, we should eliminate the loader waterfall and layout thrash we currently have.
The flow currently is
base-react.htmlfile. In dev, this comes from rspack in theindex.ejsfile. A randomloading_messageis selected.<OrganizationContainer />renders the<OrganizationLoadingIndicator />which is similar but not the exact same as the "splash screen" loader. This wipes out the randomloading_messagethat was server rendered.After this PR, the flow remains the same except for the final step. Instead of the
<OrganizationLoadingIndicator />rendering a new component, we grab theinnerHTMLof the initial "splash screen" loader. React will recognize that the VDOM matches the existing DOM and avoid reconciliation, preserving the state of our existing SSR loader (animations, messages, and all).