Skip to content

Conversation

@jennmueng
Copy link
Member

Adds the cursor logo to the Cursor Background Agent integration + a better loading state when launching one

CleanShot 2025-10-24 at 00 28 54@2x CleanShot 2025-10-24 at 00 29 41@2x
CleanShot.2025-10-24.at.00.46.02.mp4

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 23, 2025
@jennmueng jennmueng marked this pull request as ready for review October 23, 2025 18:28
@jennmueng jennmueng requested a review from a team as a code owner October 23, 2025 18:28
@jennmueng jennmueng requested a review from a team October 23, 2025 18:29
) : (
<IconChevron direction={isOpen ? 'up' : 'down'} size="xs" />
)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Conflicting Loading States in DropdownTrigger

The DropdownTrigger button uses both the busy prop and a conditional LoadingIndicator icon when isLaunchingAgent is true. This results in conflicting loading states or duplicate loading indicators.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busy doesn't show a loading indicator. it makes it disabled tho

@jennmueng jennmueng merged commit a4553c1 into master Oct 24, 2025
49 checks passed
@jennmueng jennmueng deleted the cursor-agent-branding-loading branch October 24, 2025 17:48
priscilawebdev pushed a commit that referenced this pull request Oct 28, 2025
Adds the cursor logo to the Cursor Background Agent integration + a
better loading state when launching one

<img width="402" height="176" alt="CleanShot 2025-10-24 at 00 28 54@2x"
src="https://github.com/user-attachments/assets/9a6ea432-edb3-490c-aeaa-fc62bb89a434"
/>

<img width="1042" height="560" alt="CleanShot 2025-10-24 at 00 29 41@2x"
src="https://github.com/user-attachments/assets/a1ce7e78-babb-4f69-9f1e-b296b3c94552"
/>


https://github.com/user-attachments/assets/34d72386-c707-4611-896a-30fae4082eac
shashjar pushed a commit that referenced this pull request Nov 4, 2025
Adds the cursor logo to the Cursor Background Agent integration + a
better loading state when launching one

<img width="402" height="176" alt="CleanShot 2025-10-24 at 00 28 54@2x"
src="https://github.com/user-attachments/assets/9a6ea432-edb3-490c-aeaa-fc62bb89a434"
/>

<img width="1042" height="560" alt="CleanShot 2025-10-24 at 00 29 41@2x"
src="https://github.com/user-attachments/assets/a1ce7e78-babb-4f69-9f1e-b296b3c94552"
/>


https://github.com/user-attachments/assets/34d72386-c707-4611-896a-30fae4082eac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants