Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 1, 2025

Add first class framer motion support to theme.

@gggritso I'll let you experiment with the transition definition for the drawer animation and we'll figure out if we can modify one of our current definitions or introduce a brand new one, but I'd like to defer that until we see what the desired transition would look like.

@JonasBa JonasBa requested a review from gggritso November 1, 2025 20:52
@JonasBa JonasBa requested a review from a team as a code owner November 1, 2025 20:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 1, 2025
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll tinker with the the animation next week, but my guess is:

  1. We'll need to adjust the current durations and space them out (e.g., I'd expect a "slow" animation that covers a lot of the screen to be in the 300-500ms range)
  2. We might need to introduce more sophisticated animation tokens that are physics-based, to support the current modals

In any case, I'll let you know once I try it out. Thanks for putting this together!

P.S. Maybe a little surprising that "framer" is nested at the same level as "slow" under theme.motion but TBH I was about to do the same thing

@JonasBa
Copy link
Member Author

JonasBa commented Nov 1, 2025

P.S. Maybe a little surprising that "framer" is nested at the same level as "slow" under theme.motion but TBH I was about to do the same thing

I could do something like add use String() object and then add a .framer property via proxy. That way I we could define motion.enter.fast.framer 🤔

@gggritso
Copy link
Member

gggritso commented Nov 2, 2025

@JonasBa 🤔 I leave it to you! IMO it's fine as-is, too! Good to keep things simple

@JonasBa JonasBa merged commit ac42795 into master Nov 3, 2025
49 checks passed
@JonasBa JonasBa deleted the jb/tokens/motion/framer branch November 3, 2025 15:59
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #102531      +/-   ##
===========================================
- Coverage   80.99%    80.88%   -0.11%     
===========================================
  Files        8865      8860       -5     
  Lines      392651    390421    -2230     
  Branches    24834     24832       -2     
===========================================
- Hits       318015    315786    -2229     
+ Misses      74271     74270       -1     
  Partials      365       365              

shashjar pushed a commit that referenced this pull request Nov 4, 2025
Add first class framer motion support to theme. 

@gggritso I'll let you experiment with the transition definition for the
drawer animation and we'll figure out if we can modify one of our
current definitions or introduce a brand new one, but I'd like to defer
that until we see what the desired transition would look like.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants